mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl - Issue 1526533002: [mojo] Add pickling support for native-only structs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

Issue 1526533002: [mojo] Add pickling support for native-only structs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bindings-4-bool-deserialize

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/tests/pickled_struct_chromium.h ('K') | « mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl » ('j') | mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

index a877fc7adae3af83b24a442d89b3bb9bfb3d0e3e..6d21e2fc0620bcbfd1c1610c0195c60145dcbd92 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

@@ -33,6 +33,9 @@

&{{name}}_validate_params)) {

return false;

}

+{%- elif kind|is_native_only_kind %}

+ if (!mojo::internal::ValidateNative(object->{{name}}, bounds_checker))

+ return false;

{%- elif kind|is_struct_kind %}

if (!mojo::internal::ValidateStruct(object->{{name}}, bounds_checker))

return false;