mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl - Issue 1526533002: [mojo] Add pickling support for native-only structs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 1526533002: [mojo] Add pickling support for native-only structs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bindings-4-bool-deserialize

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/tests/pickled_struct_chromium.h ('K') | « mojo/public/interfaces/bindings/tests/test_native_types.mojom ('k') | mojo/public/tools/bindings/generators/cpp_templates/module-internal.h.tmpl » ('j') | mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

index a4453131d4d701044ebef897da016f69da852661..df2ee80ab5a4207f83df0a3a5c6ae7af3574e8fd 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

@@ -9,7 +9,7 @@

{%- macro alloc_params(struct, serialization_context) %}

bool success = true;

{%- for param in struct.packed.packed_fields_in_ordinal_order %}

- {{param.field.kind|cpp_result_type}} p_{{param.field.name}}{};

+ {{param.field.kind|cpp_wrapper_type}} p_{{param.field.name}}{};

{%- endfor %}

{{struct_macros.deserialize(struct, "params", "p_%s", serialization_context, "success")}}

if (!success)