mojo/public/cpp/bindings/lib/validation_util.h - Issue 1526533002: [mojo] Add pickling support for native-only structs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/validation_util.h

Issue 1526533002: [mojo] Add pickling support for native-only structs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bindings-4-bool-deserialize

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/lib/native_serialization.h ('K') | « mojo/public/cpp/bindings/lib/native_serialization.h ('k') | mojo/public/cpp/bindings/lib/validation_util.cc » ('j') | mojo/public/cpp/bindings/lib/validation_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/lib/validation_util.h

diff --git a/mojo/public/cpp/bindings/lib/validation_util.h b/mojo/public/cpp/bindings/lib/validation_util.h

index 41049c03c9880168d6755ad4d6311dae0fe8fa88..0af6341e056326d50a21ff6aee4a020e68bd3e69 100644

--- a/mojo/public/cpp/bindings/lib/validation_util.h

+++ b/mojo/public/cpp/bindings/lib/validation_util.h

@@ -124,6 +124,8 @@ bool ValidateHandle(const Handle& input, BoundsChecker* bounds_checker);

bool ValidateAssociatedInterfaceId(InterfaceId input);

+bool ValidateNative(const NativePointer& input, BoundsChecker* bounds_checker);

yzshen1 2015/12/15 21:20:27 Please add validation tests. (Not necessarily in t

Ken Rockot(use gerrit already) 2015/12/15 23:31:08 No longer needed as we just use array validation n

} // namespace internal

} // namespace mojo