mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl - Issue 1526533002: [mojo] Add pickling support for native-only structs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl

Issue 1526533002: [mojo] Add pickling support for native-only structs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bindings-4-bool-deserialize

Patch Set: merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl

index 8c61c86ab18527ffdcb80e789d8aee1a44c4e6a2..279665296f1f6e2d82c6dc3f569e057b1baa9586 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl

@@ -37,8 +37,13 @@

bool {{struct.name}}::Equals(const {{struct.name}}& other) const {

{%- for field in struct.fields %}

+{%- if field.kind|is_typemapped_kind %}

+{# TODO(rockot): Consider adding support for native equality testing. #}

+ NOTREACHED() << "Equality testing not supported with typemapped fields.";

+{%- else %}

if (!mojo::internal::ValueTraits<{{field.kind|cpp_wrapper_type}}>::Equals(this->{{field.name}}, other.{{field.name}}))

return false;

+{%- endif %}

{%- endfor %}

return true;

}