mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl - Issue 1526533002: [mojo] Add pickling support for native-only structs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

Issue 1526533002: [mojo] Add pickling support for native-only structs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bindings-4-bool-deserialize

Patch Set: merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

index a877fc7adae3af83b24a442d89b3bb9bfb3d0e3e..6a8254949795698009140db45bd03393bedcc70c 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

@@ -19,7 +19,8 @@

}

{%- endif %}

-{%- if kind|is_array_kind or kind|is_string_kind %}

+{%- if kind|is_array_kind or kind|is_string_kind or

+ kind|is_native_only_kind %}

const mojo::internal::ArrayValidateParams {{name}}_validate_params(

{{kind|get_array_validate_params_ctor_args|indent(6)}});

if (!mojo::internal::ValidateArray(object->{{name}}, bounds_checker,