Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: Source/core/platform/network/ResourceLoadTiming.h

Issue 15265004: Fix ResourceLoadTiming resolution lose issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/platform/network/ResourceLoadTiming.h
diff --git a/Source/core/platform/network/ResourceLoadTiming.h b/Source/core/platform/network/ResourceLoadTiming.h
index 2a395ef7c4b0a7f346bc21190655b0549590f5c8..88364e9bd32607332dfdb003f6693405412f32ed 100644
--- a/Source/core/platform/network/ResourceLoadTiming.h
+++ b/Source/core/platform/network/ResourceLoadTiming.h
@@ -83,37 +83,35 @@ public:
// We want to present a unified timeline to Javascript. Using walltime is problematic, because the clock may skew while resources
// load. To prevent that skew, we record a single reference walltime when root document navigation begins. All other times are
// recorded using monotonicallyIncreasingTime(). When a time needs to be presented to Javascript, we build a pseudo-walltime
- // using the following equation:
- // pseudo time = document wall reference + (resource request time - document monotonic reference) + deltaMilliseconds / 1000.0.
- double convertResourceLoadTimeToMonotonicTime(int deltaMilliseconds) const;
-
- double requestTime; // monotonicallyIncreasingTime() when the port started handling this request.
- int proxyStart; // The rest of these are millisecond deltas, using monotonicallyIncreasingTime(), from requestTime.
- int proxyEnd;
- int dnsStart;
- int dnsEnd;
- int connectStart;
- int connectEnd;
- int sendStart;
- int sendEnd;
- int receiveHeadersEnd;
- int sslStart;
- int sslEnd;
+ // using the following equation (requestTime as example):
+ // pseudo time = document wall reference + (requestTime - document monotonic reference).
+ double requestTime; // All monotonicallyIncreasingTime() in seconds
+ double proxyStart;
+ double proxyEnd;
+ double dnsStart;
+ double dnsEnd;
+ double connectStart;
+ double connectEnd;
+ double sendStart;
+ double sendEnd;
+ double receiveHeadersEnd;
+ double sslStart;
+ double sslEnd;
private:
ResourceLoadTiming()
: requestTime(0)
- , proxyStart(-1)
- , proxyEnd(-1)
- , dnsStart(-1)
- , dnsEnd(-1)
- , connectStart(-1)
- , connectEnd(-1)
+ , proxyStart(0)
+ , proxyEnd(0)
+ , dnsStart(0)
+ , dnsEnd(0)
+ , connectStart(0)
+ , connectEnd(0)
, sendStart(0)
, sendEnd(0)
, receiveHeadersEnd(0)
- , sslStart(-1)
- , sslEnd(-1)
+ , sslStart(0)
+ , sslEnd(0)
{
}
};

Powered by Google App Engine
This is Rietveld 408576698