Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1526463005: Emit Timeline events for most Dart_API calls (Closed)

Created:
5 years ago by Cutch
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Emit Timeline events for most Dart_API calls - Remove --trace-api and related macros. - Emit Timeline events on the API stream for Dart_API calls. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/2ff1c28978870d7b37ed4abf1b20d59b82396da4

Patch Set 1 #

Patch Set 2 : #

Total comments: 20

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -49 lines) Patch
M runtime/vm/dart_api_impl.h View 3 chunks +0 lines, -14 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 56 chunks +57 lines, -34 lines 0 comments Download
M runtime/vm/timeline.h View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/timeline.cc View 5 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Cutch
5 years ago (2015-12-14 23:17:29 UTC) #3
rmacnak
https://chromiumcodereview.appspot.com/1526463005/diff/20001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://chromiumcodereview.appspot.com/1526463005/diff/20001/runtime/vm/dart_api_impl.cc#newcode711 runtime/vm/dart_api_impl.cc:711: API_TIMELINE_DURATION; For all the Dart_IsX, I don't think it ...
5 years ago (2015-12-15 17:42:04 UTC) #4
Cutch
https://codereview.chromium.org/1526463005/diff/20001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1526463005/diff/20001/runtime/vm/dart_api_impl.cc#newcode711 runtime/vm/dart_api_impl.cc:711: API_TIMELINE_DURATION; On 2015/12/15 17:42:04, rmacnak wrote: > For all ...
5 years ago (2015-12-15 18:06:40 UTC) #5
rmacnak
lgtm
5 years ago (2015-12-15 18:25:55 UTC) #6
Cutch
5 years ago (2015-12-15 18:27:27 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
2ff1c28978870d7b37ed4abf1b20d59b82396da4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698