Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1526453002: Add logging service documentation. (Closed)

Created:
5 years ago by iannucci
Modified:
5 years ago
Reviewers:
dnj, Vadim Sh., estaab
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@cursorcb
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Add logging service documentation. Just points to github.com/luci/luci-go/common/logging, but explains how that works and meshes with the rest of the service definitions. R=dnj@chromium.org, estaab@chromium.org, vadimsh@chromium.org BUG=https://github.com/luci/gae/issues/22 Committed: https://github.com/luci/gae/commit/204a9a9fedfdd27ab6f6ab523d90a53220c2c23c

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
A service/logging/logging.go View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
iannucci
5 years ago (2015-12-13 18:54:16 UTC) #1
Vadim Sh.
lgtm
5 years ago (2015-12-13 21:22:15 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1521823003 Patch 1). Please resolve the dependency and ...
5 years ago (2015-12-14 01:37:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526453002/20001
5 years ago (2015-12-14 08:50:00 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-14 08:52:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/204a9a9fedfdd27ab6f6ab523d90a53220c2c23c

Powered by Google App Engine
This is Rietveld 408576698