Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 152643010: Allow a bit of wiggle room in highlight's bounding box (Closed)

Created:
6 years, 10 months ago by shatch
Modified:
6 years, 10 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Allow a bit of wiggle room in highlight's bounding box. This should help reduce the noise on speed index. Previously, we were searching through the frames for when the orange highlight disappears, but with compression artifacts we might see a slight variations in each frame's highlight bounding box. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251010

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Changes from review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M tools/telemetry/telemetry/core/tab.py View 1 4 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
shatch
6 years, 10 months ago (2014-02-13 01:11:55 UTC) #1
tonyg
lgtm https://codereview.chromium.org/152643010/diff/20001/tools/telemetry/telemetry/core/tab.py File tools/telemetry/telemetry/core/tab.py (right): https://codereview.chromium.org/152643010/diff/20001/tools/telemetry/telemetry/core/tab.py#newcode182 tools/telemetry/telemetry/core/tab.py:182: if bounds_difference > 4: We've hardcoded 4 and ...
6 years, 10 months ago (2014-02-13 01:16:40 UTC) #2
shatch
The CQ bit was checked by simonhatch@chromium.org
6 years, 10 months ago (2014-02-13 01:26:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/152643010/90001
6 years, 10 months ago (2014-02-13 01:28:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 04:25:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263155
6 years, 10 months ago (2014-02-13 04:25:21 UTC) #6
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 10 months ago (2014-02-13 05:35:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/152643010/90001
6 years, 10 months ago (2014-02-13 05:36:34 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 15:06:59 UTC) #9
Message was sent while issue was closed.
Change committed as 251010

Powered by Google App Engine
This is Rietveld 408576698