ui/events/keycodes/keyboard_code_conversion_mac.h - Issue 152643007: mac: Create a static mapping of accelerators in the main menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/keycodes/keyboard_code_conversion_mac.h

Issue 152643007: mac: Create a static mapping of accelerators in the main menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@acc_list

Patch Set: Minor fix: Fix compile error on mac_rel. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm ('K') | « ui/base/accelerators/platform_accelerator_cocoa.h ('k') | ui/events/keycodes/keyboard_code_conversion_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/keycodes/keyboard_code_conversion_mac.h

diff --git a/ui/events/keycodes/keyboard_code_conversion_mac.h b/ui/events/keycodes/keyboard_code_conversion_mac.h

index 719c922d1395d933ea0df607c5c948f1968f91d4..fee39815d426ebcff1cea2478c65c226921d0050 100644

--- a/ui/events/keycodes/keyboard_code_conversion_mac.h

+++ b/ui/events/keycodes/keyboard_code_conversion_mac.h

@@ -16,8 +16,8 @@ namespace ui {

// We use windows virtual keycodes throughout our keyboard event related code,

// including unit tests. But Mac uses a different set of virtual keycodes.

// This function converts a windows virtual keycode into Mac's virtual key code

-// and corresponding unicode character. |flags| is the modifiers mask such

-// as NSControlKeyMask, NSShiftKeyMask, etc.

+// and corresponding unicode character. |flags| is the Cocoa modifiers mask

+// such as NSControlKeyMask, NSShiftKeyMask, etc.

// When success, the corresponding Mac's virtual key code will be returned.

// The corresponding unicode character will be stored in |character|, and the

// corresponding unicode character ignoring the modifiers will be stored in