Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 152643006: Make LeakSanitizer happy, part 1. (Closed)

Created:
6 years, 10 months ago by Sven Panne
Modified:
6 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Make LeakSanitizer happy, part 1. Bumped an assembler buffer on the way, it is necessary for some combinations of debugging flags. Note that the allocation profiler still leaks, this is handled in a separate CL. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -26 lines) Patch
M test/cctest/test-heap-profiler.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M test/cctest/test-log.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Benedikt Meurer
lgtm
6 years, 10 months ago (2014-02-06 06:35:04 UTC) #1
Sven Panne
6 years, 10 months ago (2014-02-06 07:16:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r19128 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698