Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 152643002: Create PasswordManagerDriver and ContentPasswordManagerDriver. (Closed)

Created:
6 years, 10 months ago by blundell
Modified:
6 years, 10 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, vabr (Chromium), Patrick Dubroy
Visibility:
Public.

Description

Create PasswordManagerDriver and ContentPasswordManagerDriver. This CL carves the PasswordManagerDriver driver interface for the PasswordManager component out of the PasswordManagerDelegate interface, which will be the embedder-level interface for the component. It also creates the ContentPasswordManagerDriver //content-based implementation of the driver interface and sets up the ownership relationship between ContentPasswordManagerDriver and PasswordManagerDelegateImpl. This CL does not yet publically expose the PasswordManagerDriver interface to the PasswordManager core code, instead having PasswordManagerDelegateImpl forward calls to ContentPasswordManagerDriver. Follow-up CLs will eliminate this forwarding. BUG=335096 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248487

Patch Set 1 #

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -21 lines) Patch
A chrome/browser/password_manager/content_password_manager_driver.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/password_manager/content_password_manager_driver.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_manager_delegate_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_manager_delegate_impl.cc View 4 chunks +4 lines, -21 lines 0 comments Download
A chrome/browser/password_manager/password_manager_driver.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
blundell
6 years, 10 months ago (2014-02-03 11:08:32 UTC) #1
Garrett Casto
lgtm
6 years, 10 months ago (2014-02-03 12:08:33 UTC) #2
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 10 months ago (2014-02-03 12:09:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/152643002/30001
6 years, 10 months ago (2014-02-03 12:09:51 UTC) #4
commit-bot: I haz the power
Change committed as 248487
6 years, 10 months ago (2014-02-03 14:11:31 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 14:11:36 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 14:11:40 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698