Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152633003: On enterprise machines read policy from the registry. (Closed)

Created:
6 years, 10 months ago by pastarmovj
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

On enterprise machines read policy from the registry. This will allow the usage of third party policy management software in enteprise deployments of Chrome on Windows. BUG=259236 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253358

Patch Set 1 #

Total comments: 2

Patch Set 2 : Split the VLOG. #

Total comments: 2

Patch Set 3 : Moved comment. #

Patch Set 4 : Fixed the tests and added a new one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M components/policy/core/common/policy_loader_win.cc View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 1 2 3 5 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
pastarmovj
Please review this CL when you have time. Thanks, Jul
6 years, 10 months ago (2014-02-05 12:50:50 UTC) #1
Mattias Nissler (ping if slow)
https://codereview.chromium.org/152633003/diff/1/components/policy/core/common/policy_loader_win.cc File components/policy/core/common/policy_loader_win.cc (right): https://codereview.chromium.org/152633003/diff/1/components/policy/core/common/policy_loader_win.cc#newcode380 components/policy/core/common/policy_loader_win.cc:380: << scope << " falling back to registry."; This ...
6 years, 10 months ago (2014-02-05 13:23:42 UTC) #2
pastarmovj
https://codereview.chromium.org/152633003/diff/1/components/policy/core/common/policy_loader_win.cc File components/policy/core/common/policy_loader_win.cc (right): https://codereview.chromium.org/152633003/diff/1/components/policy/core/common/policy_loader_win.cc#newcode380 components/policy/core/common/policy_loader_win.cc:380: << scope << " falling back to registry."; On ...
6 years, 10 months ago (2014-02-05 14:05:44 UTC) #3
pastarmovj
PTAL.
6 years, 10 months ago (2014-02-05 16:08:39 UTC) #4
Mattias Nissler (ping if slow)
https://codereview.chromium.org/152633003/diff/60001/components/policy/core/common/policy_loader_win.cc File components/policy/core/common/policy_loader_win.cc (right): https://codereview.chromium.org/152633003/diff/60001/components/policy/core/common/policy_loader_win.cc#newcode422 components/policy/core/common/policy_loader_win.cc:422: << (is_enterprise ? "enabled." : "disabled."); Move this before ...
6 years, 10 months ago (2014-02-06 10:13:57 UTC) #5
pastarmovj
Moved log. PTAL. https://codereview.chromium.org/152633003/diff/60001/components/policy/core/common/policy_loader_win.cc File components/policy/core/common/policy_loader_win.cc (right): https://codereview.chromium.org/152633003/diff/60001/components/policy/core/common/policy_loader_win.cc#newcode422 components/policy/core/common/policy_loader_win.cc:422: << (is_enterprise ? "enabled." : "disabled."); ...
6 years, 10 months ago (2014-02-06 12:30:03 UTC) #6
Mattias Nissler (ping if slow)
LGTM
6 years, 10 months ago (2014-02-06 12:37:22 UTC) #7
pastarmovj
The CQ bit was checked by pastarmovj@chromium.org
6 years, 10 months ago (2014-02-06 12:38:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/152633003/120001
6 years, 10 months ago (2014-02-06 12:39:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/152633003/120001
6 years, 10 months ago (2014-02-06 13:35:16 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 17:57:09 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) components_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=258986
6 years, 10 months ago (2014-02-06 17:57:10 UTC) #12
pastarmovj
Mattias, can you PTAL. I changed/added some tests for this code now.
6 years, 10 months ago (2014-02-12 13:18:55 UTC) #13
Mattias Nissler (ping if slow)
LGTM
6 years, 10 months ago (2014-02-12 13:55:21 UTC) #14
pastarmovj
The CQ bit was checked by pastarmovj@chromium.org
6 years, 10 months ago (2014-02-25 15:19:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/152633003/500001
6 years, 10 months ago (2014-02-25 15:20:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/152633003/500001
6 years, 10 months ago (2014-02-25 21:44:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/152633003/500001
6 years, 10 months ago (2014-02-25 22:08:36 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/152633003/500001
6 years, 10 months ago (2014-02-25 23:05:55 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/152633003/500001
6 years, 10 months ago (2014-02-25 23:57:46 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 05:14:26 UTC) #21
Message was sent while issue was closed. 
Change committed as 253358

Powered by Google App Engine
This is Rietveld 408576698