Issue 1526313003: Fix a snackbar crash about leaking window

Issue 1526313003: Fix a snackbar crash about leaking window (Closed)

Created:
5 years ago by Ian Wen

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

Fix a snackbar crash about leaking window Sometimes the DownloadService will call showSnackbars() even when the activity is not visible. To track the activity's visibility, SnackbarManager now needs to know some activity's lifecycle signals. After this CL, all activities managing snackbars should call onStart and onStop of the SnackbarManager. BUG=553569 TBR=newt@chromium.org Review URL: https://codereview.chromium.org/1518373002 Cr-Commit-Position: refs/heads/master@{#365751} Committed: https://chromium.googlesource.com/chromium/src/+/b006defc621c8cd2f168e2c29237c2c7daa014f6

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -8 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivity.java	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java	View	4 chunks	+23 lines, -1 line	0 comments	Download

Total messages: 3 (2 generated)

Ian Wen

5 years ago (2015-12-17 05:51:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b006defc621c8cd2f168e2c29237c2c7daa014f6 (presubmit successful).