Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: media/base/pipeline_unittest.cc

Issue 1526303004: Fix buffered range updates in media::Pipeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline_unittest.cc
diff --git a/media/base/pipeline_unittest.cc b/media/base/pipeline_unittest.cc
index 6c0dfcf79f17f16ef929528898491e0cb5f43da3..5532b2039a595df8477e61c8936a8dd984e87ac7 100644
--- a/media/base/pipeline_unittest.cc
+++ b/media/base/pipeline_unittest.cc
@@ -657,7 +657,9 @@ TEST_F(PipelineTest, GetBufferedTimeRanges) {
EXPECT_EQ(0u, pipeline_->GetBufferedTimeRanges().size());
EXPECT_FALSE(pipeline_->DidLoadingProgress());
- pipeline_->AddBufferedTimeRange(base::TimeDelta(), kDuration / 8);
+ Ranges<base::TimeDelta> ranges;
+ ranges.Add(base::TimeDelta::FromSeconds(0), kDuration / 8);
wolenetz 2016/01/06 19:28:41 nit: just base::TimeDelta() is much more frequentl
servolk 2016/01/06 21:05:05 Done.
wolenetz 2016/01/14 19:25:53 Friendly nit ping (it's still FromSeconds(0) in pa
wolenetz 2016/01/14 19:53:06 Still a nit :)
+ pipeline_->OnBufferedTimeRangesChanged(ranges);
EXPECT_TRUE(pipeline_->DidLoadingProgress());
EXPECT_FALSE(pipeline_->DidLoadingProgress());
EXPECT_EQ(1u, pipeline_->GetBufferedTimeRanges().size());

Powered by Google App Engine
This is Rietveld 408576698