Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: media/base/demuxer.h

Issue 1526303004: Fix buffered range updates in media::Pipeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/demuxer.h
diff --git a/media/base/demuxer.h b/media/base/demuxer.h
index 1f136a0cbcccd6e93f1ad85804407c9ecb1a4d04..c164cf17df61aaa3e5d348dbdf43e37ed5461a5f 100644
--- a/media/base/demuxer.h
+++ b/media/base/demuxer.h
@@ -14,6 +14,7 @@
#include "media/base/eme_constants.h"
#include "media/base/media_export.h"
#include "media/base/pipeline_status.h"
+#include "media/base/ranges.h"
namespace media {
@@ -21,9 +22,12 @@ class TextTrackConfig;
class MEDIA_EXPORT DemuxerHost {
public:
- // Notify the host that time range [start,end] has been buffered.
- virtual void AddBufferedTimeRange(base::TimeDelta start,
- base::TimeDelta end) = 0;
+ // Notify the host that buffered time ranges have changed. Note that buffered
+ // time ranges can grow (when new media data is appended), but they can also
+ // shrink (when buffering reaches limit capacity and some buffered data
+ // becomes evicted, e.g. due to MSE GC algorithm).
wolenetz 2016/01/06 19:28:40 nit: or by explicit removal of ranges directed by
wolenetz 2016/01/14 19:25:53 ping on this nit.
servolk 2016/01/14 19:28:54 Done.
+ virtual void OnBufferedTimeRangesChanged(
+ const Ranges<base::TimeDelta>& ranges) = 0;
// Sets the duration of the media in microseconds.
// Duration may be kInfiniteDuration() if the duration is not known.

Powered by Google App Engine
This is Rietveld 408576698