Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1526303003: convert ImportedReferenceContributor to new API (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1160 lines, -6558 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 3 chunks +14 lines, -2 lines 0 comments Download
A pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart View 1 chunk +96 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart View 7 chunks +61 lines, -34 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 2 chunks +1 line, -2 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart View 1 chunk +0 lines, -245 lines 0 comments Download
D pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +0 lines, -4675 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart View 164 chunks +936 lines, -783 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/library_member_contributor_test.dart View 1 chunk +10 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_library_contributor_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
D pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart View 1 chunk +0 lines, -812 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-16 23:00:01 UTC) #2
scheglov
LGTM
5 years ago (2015-12-17 01:29:15 UTC) #3
danrubel
5 years ago (2015-12-17 02:17:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0de484bb8b85ecb6029fda8a0c4915d7bc904458 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698