Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Issue 15263004: Adding isNotEmpty property to collection and string. (Closed)

Created:
7 years, 7 months ago by qsr
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Adding isNotEmpty property to collection and string. BUG= http://dartbug.com/3074 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=23294

Patch Set 1 #

Patch Set 2 : Rename hasElement to isNotEmpty #

Total comments: 1

Patch Set 3 : Fix template generation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -47 lines) Patch
M pkg/mdv_observe/lib/src/observable_map.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/serialization/lib/src/serialization_helpers.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/serialization/lib/src/serialization_rule.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/yaml/lib/src/yaml_map.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/lib/array.dart View 1 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/lib/collection_patch.dart View 1 4 chunks +8 lines, -0 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/immutable_map.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/string_patch.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/typed_data.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M samples/swarm/swarm_ui_lib/observable/observable.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_collection_dev/list.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/code_buffer.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart View 1 4 chunks +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/constant_map.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_string.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/util.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/collection/hash_map.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/collection/hash_set.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/collection/iterable.dart View 1 2 chunks +4 lines, -0 lines 0 comments Download
M sdk/lib/collection/linked_hash_map.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/collection/linked_hash_set.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/collection/list.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/collection/maps.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/collection/splay_tree.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/iterable.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/core/map.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/core/string.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/core/string_buffer.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 3 chunks +9 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +10 lines, -0 lines 0 comments Download
M sdk/lib/html/html_common/css_class_set.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/buffer_list.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/io/http_session.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 1 9 chunks +18 lines, -0 lines 0 comments Download
M tests/corelib/collection_length_test.dart View 1 1 chunk +4 lines, -3 lines 0 comments Download
M tests/corelib/core_runtime_types_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/list_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/map_test.dart View 1 7 chunks +27 lines, -21 lines 0 comments Download
M tests/corelib/queue_test.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/corelib/set_test.dart View 1 3 chunks +16 lines, -10 lines 0 comments Download
M tests/corelib/string_buffer_test.dart View 1 5 chunks +16 lines, -10 lines 0 comments Download
M tests/corelib/string_test.dart View 1 4 chunks +16 lines, -2 lines 0 comments Download
M tests/html/custom_element_bindings_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/src/AttributeMap.dart View 1 2 chunks +7 lines, -0 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Storage.darttemplate View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qsr
This is a patch for dartbug.com/4329 As this is a change of the API for ...
7 years, 7 months ago (2013-05-17 08:06:51 UTC) #1
ahe
This is Florian and Lasse's area.
7 years, 7 months ago (2013-05-17 08:13:10 UTC) #2
floitsch
Make sure that the html libraries are correctly generated, and change the title of this ...
7 years, 7 months ago (2013-05-27 11:29:08 UTC) #3
qsr
Changes to template file done. You will need to push this for me, I'm not ...
7 years, 7 months ago (2013-05-27 12:00:34 UTC) #4
floitsch
7 years, 6 months ago (2013-05-28 17:31:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r23294 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698