Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 1526293003: Gracefully discharge a failed script load in disposed documents. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
haraken, Nate Chapin
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gracefully discharge a failed script load in disposed documents. Should a ScriptLoader's resource end up being cancelled as part of Document and ScriptRunner disposal, handle the error notification without falsely asserting. Speculative crash fix. R=haraken BUG=536796 Committed: https://crrev.com/d192ed6d01bccd58a7d4f0ccc281725f6ba4e037 Cr-Commit-Position: refs/heads/master@{#365541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 4 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
5 years ago (2015-12-16 13:59:43 UTC) #2
haraken
LGTM
5 years ago (2015-12-16 14:58:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526293003/1
5 years ago (2015-12-16 15:18:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 16:34:14 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-16 16:36:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d192ed6d01bccd58a7d4f0ccc281725f6ba4e037
Cr-Commit-Position: refs/heads/master@{#365541}

Powered by Google App Engine
This is Rietveld 408576698