Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 1526263003: Position autofill popup widgets correctly under --site-per-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments addressed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index a2a0884d005c4f058ad63335280959bd01460114..ca225b949126c17c5f22bed6052da840d5d7df2e 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -14,6 +14,7 @@
#include "content/common/content_switches_internal.h"
#include "content/public/browser/render_widget_host_view_frame_subscriber.h"
#include "ui/gfx/display.h"
+#include "ui/gfx/geometry/point_conversions.h"
#include "ui/gfx/geometry/size_conversions.h"
#include "ui/gfx/geometry/size_f.h"
#include "ui/gfx/screen.h"
@@ -682,10 +683,15 @@ uint32_t RenderWidgetHostViewBase::SurfaceIdNamespaceAtPoint(
return 0;
}
-void RenderWidgetHostViewBase::TransformPointToRootCoordSpace(
- const gfx::Point& point,
- gfx::Point* transformed_point) {
- *transformed_point = point;
+gfx::Point RenderWidgetHostViewBase::TransformPointToRootCoordSpace(
+ const gfx::Point& point) {
+ return point;
+}
+
+gfx::PointF RenderWidgetHostViewBase::TransformPointToRootCoordSpaceF(
+ const gfx::PointF& point) {
+ return (gfx::PointF)TransformPointToRootCoordSpace(
Charlie Reis 2016/01/22 23:04:54 This should be a C++ style cast (static_cast), rig
kenrb 2016/01/25 22:41:40 Thanks for catching that, it wasn't supposed to be
Charlie Reis 2016/01/26 04:51:24 Ah, that makes much more sense! LGTM.
+ gfx::ToRoundedPoint(point));
}
void RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/public/browser/render_frame_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698