content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 1526263003: Position autofill popup widgets correctly under --site-per-process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 1526263003: Position autofill popup widgets correctly under --site-per-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_child_frame.h ('k') | content/browser/renderer_host/render_widget_host_view_base.h » ('j') | content/browser/renderer_host/render_widget_host_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index e8d384e723357b82d591899957195371b596131e..5d1e3e76840039513b540eabf2ec8554352675b0 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -381,15 +381,12 @@ void RenderWidgetHostViewChildFrame::ProcessMouseWheelEvent(

host_->ForwardWheelEvent(event);

}

-void RenderWidgetHostViewChildFrame::TransformPointToRootCoordSpace(

- const gfx::Point& point,

- gfx::Point* transformed_point) {

- *transformed_point = point;

+gfx::Point RenderWidgetHostViewChildFrame::TransformPointToRootCoordSpace(

+ const gfx::Point& point) {

if (!frame_connector_ || !use_surfaces_)

- return;

+ return point;

- frame_connector_->TransformPointToRootCoordSpace(point, surface_id_,

- transformed_point);

+ return frame_connector_->TransformPointToRootCoordSpace(point, surface_id_);

}

#if defined(OS_MACOSX)