components/autofill/core/browser/autofill_manager.cc - Issue 1526263003: Position autofill popup widgets correctly under --site-per-process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 1526263003: Position autofill popup widgets correctly under --site-per-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mo IOS fixin Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_driver.h ('K') | « components/autofill/core/browser/autofill_driver.h ('k') | components/autofill/core/browser/test_autofill_driver.h » ('j') | components/autofill/core/browser/test_autofill_driver.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 8e2787c4c818f7fbe3b32eb6c4574dc0dd07807d..e92068d8df61fa5c746952ddce99ae976c6f17fb 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -387,7 +387,8 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,

std::vector<Suggestion> suggestions;

- external_delegate_->OnQuery(query_id, form, field, bounding_box);

+ gfx::RectF transformed_box = driver_->TransformBoundingBox(bounding_box);

+ external_delegate_->OnQuery(query_id, form, field, transformed_box);

// Need to refresh models before using the form_event_loggers.

bool is_autofill_possible = RefreshDataModels();