Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1526253006: MIPS: Fix `[proxies] fix access issue when having proxies on the prototype-chain of global objects.` (Closed)

Created:
5 years ago by balazs.kilvady
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix `[proxies] fix access issue when having proxies on the prototype-chain of global objects.` Port 2c75e3d2abc3eba3337a09afcd0dfa3e653ff006 Original commit message: We can no longer just walk the prototype chain without doing proper access-checks. When installing a proxy as the __proto__ of the global object we might accidentally end up invoking cross-realm code without access-checks (see proxies-cross-realm-ecxeption.js). BUG= Committed: https://crrev.com/bc55af3c97d6a7552a409e1b79158c3192908c57 Cr-Commit-Position: refs/heads/master@{#32921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
balazs.kilvady
5 years ago (2015-12-16 20:16:01 UTC) #2
paul.l...
LGTM. cbruni, sorry I missed this in your CL last night, I should have added ...
5 years ago (2015-12-16 20:18:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526253006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526253006/1
5 years ago (2015-12-16 20:33:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 20:49:04 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-16 20:49:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc55af3c97d6a7552a409e1b79158c3192908c57
Cr-Commit-Position: refs/heads/master@{#32921}

Powered by Google App Engine
This is Rietveld 408576698