Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 1526253003: Linux: Correctly count the number of open file descriptors. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux: Correctly count the number of open file descriptors. The initial implementation of ProcessMetrics::GetOpenFdCount() counted "." and ".." as well. Add a unit test to verify the counting is correct. BUG=496957 Committed: https://crrev.com/cf4c85b1897bf9b1f62e4c48a4faf122958c3790 Cr-Commit-Position: refs/heads/master@{#365504}

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -29 lines) Patch
M base/files/dir_reader_fallback.h View 1 chunk +1 line, -1 line 0 comments Download
M base/files/dir_reader_linux.h View 2 chunks +3 lines, -2 lines 0 comments Download
M base/process/process_metrics_linux.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M base/process/process_metrics_unittest.cc View 8 chunks +90 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
To punish myself for being a bad reviewer, here's a follow up CL with a ...
5 years ago (2015-12-16 03:09:34 UTC) #2
rickyz (no longer on Chrome)
lgtm You're awesome - thanks for picking this up/adding a test!
5 years ago (2015-12-16 03:42:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526253003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526253003/20001
5 years ago (2015-12-16 07:17:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-16 08:33:38 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/cf4c85b1897bf9b1f62e4c48a4faf122958c3790 Cr-Commit-Position: refs/heads/master@{#365504}
5 years ago (2015-12-16 08:34:23 UTC) #8
afakhry
5 years ago (2015-12-16 18:22:58 UTC) #9
Message was sent while issue was closed.
On 2015/12/16 08:34:23, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/cf4c85b1897bf9b1f62e4c48a4faf122958c3790
> Cr-Commit-Position: refs/heads/master@{#365504}

Thank you so much! I like the test!

Powered by Google App Engine
This is Rietveld 408576698