Introduce code to resynthesize element models from summaries.

Introduce code to resynthesize element models from summaries.

A lot of work remains to do (see TODO comments), but the basic
infrastructure is now in place.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/ea7e6b29edc9231824e82f0bca170a92cdc97bd3

[Paul Berry, 2015-12-15 22:51:26]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2015-12-16 00:29:07]

LGTM

https://codereview.chromium.org/1526243002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1526243002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:250: classElement = new
ClassElementImpl(serializedClass.name, -1);
Unless I'm missing something, this line is inside both the 'then' and 'else'
clauses.

https://codereview.chromium.org/1526243002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:349: new
ClassElementImpl(serializedEnum.name, -1);
I assume that we'll get offsets at some point.

[scheglov, 2015-12-16 01:46:49]

LGTM

https://codereview.chromium.org/1526243002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1526243002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:148: Element element =
libraryMap[location.components[1]]
Can this expression be null?

https://codereview.chromium.org/1526243002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:335:
constructorElement.setModifier(Modifier.FACTORY, true);
ConstructorElementImpl has a setter "factory".
...and the setter "const2".
Ouch.

[Paul Berry, 2015-12-16 16:34:20]

https://codereview.chromium.org/1526243002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1526243002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:148: Element element =
libraryMap[location.components[1]]
On 2015/12/16 01:46:49, scheglov wrote:
> Can this expression be null?

Good point.  It could happen, if files are updated and we forget to re-link
them, or there is a bug in the re-linking logic (which has not yet been
written).  Either of those circumstances could lead to one summary's "prelinked"
information referring to a compilation unit which does not exist.

I've added additional error checking logic to catch this scenario, and I've also
updated the exception below to say "Element not found in summary: $location" so
that if this situation ever does arise, it will be easier to figure out what
happened.

https://codereview.chromium.org/1526243002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:250: classElement = new
ClassElementImpl(serializedClass.name, -1);
On 2015/12/16 00:29:07, Brian Wilkerson wrote:
> Unless I'm missing something, this line is inside both the 'then' and 'else'
> clauses.

Oops, you're right.  Fixed.

https://codereview.chromium.org/1526243002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:335:
constructorElement.setModifier(Modifier.FACTORY, true);
On 2015/12/16 01:46:49, scheglov wrote:
> ConstructorElementImpl has a setter "factory".
> ...and the setter "const2".
> Ouch.

Good point.  I'll do a follow-up commit that replaces these calls to
`setModifier` with calls to the appropriate setters where possible.

https://codereview.chromium.org/1526243002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:349: new
ClassElementImpl(serializedEnum.name, -1);
On 2015/12/16 00:29:07, Brian Wilkerson wrote:
> I assume that we'll get offsets at some point.

Yes, that's the plan.  I've added a TODO comment to capture this.

[Paul Berry, 2015-12-16 16:40:01]

Description was changed from

==========
Introduce code to resynthesize element models from summaries.

A lot of work remains to do (see TODO comments), but the basic
infrastructure is now in place.
==========

to

==========
Introduce code to resynthesize element models from summaries.

A lot of work remains to do (see TODO comments), but the basic
infrastructure is now in place.

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ea7e6b29edc9231824e82f0bca170a92cdc97bd3
==========

[Paul Berry, 2015-12-16 16:40:03]

Committed patchset #1 (id:1) manually as
ea7e6b29edc9231824e82f0bca170a92cdc97bd3 (presubmit successful).