third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 1526183004: Prevent SharedArrayBuffer views from being used in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 1526183004: Prevent SharedArrayBuffer views from being used in bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: some tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_methods.py ('k') | third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index c89004f21a4e69510419d5b32d8dd596621034f7..3379b62c1a74f435daab52e2771c0c9bfd3710dc 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -80,6 +80,10 @@ IdlType.is_array_buffer_or_view = property(

IdlType.is_typed_array = property(

lambda self: self.base_type in TYPED_ARRAY_TYPES)

+IdlType.is_array_buffer_view = property(

+ lambda self: (self.base_type in TYPED_ARRAY_TYPES or

+ self.base_type in ('ArrayBufferView', 'DataView')))

IdlType.is_wrapper_type = property(

lambda self: (self.is_interface_type and

not self.is_callback_interface and