Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1526183002: Revert of [Android] Add ChromiumNetTestSupport.apk for the java EmbeddedTestServer. (Closed)

Created:
5 years ago by danakj
Modified:
5 years ago
Reviewers:
jbudorick, agrieve, Nico, Ted C, Yaron, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, vmpstr+watch_chromium.org, mikecase+watch_chromium.org, klundberg+watch_chromium.org, jbudorick+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add ChromiumNetTestSupport.apk for the java EmbeddedTestServer. (patchset #13 id:240001 of https://codereview.chromium.org/1465383003/ ) Reason for revert: Android compile failing with related error: https://code.google.com/p/chromium/issues/detail?id=569991 Original issue's description: > [Android] Add ChromiumNetTestSupport.apk for the java EmbeddedTestServer. > > BUG=488195 > > Committed: https://crrev.com/06215e9286247b08ff6c958f725c6e5185c4acd1 > Cr-Commit-Position: refs/heads/master@{#365254} TBR=tedchoc@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,mef@chromium.org,thakis@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488195 Committed: https://crrev.com/eb58d9c805c50f85e4a04258523cf49e5c7cc5bb Cr-Commit-Position: refs/heads/master@{#365309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -707 lines) Patch
M base/BUILD.gn View 2 chunks +0 lines, -11 lines 0 comments Download
M base/android/java/templates/NativeLibraries.template View 1 chunk +2 lines, -10 lines 0 comments Download
M base/base.gyp View 2 chunks +0 lines, -15 lines 0 comments Download
D base/test/android/java/templates/NativeTestLibraries.template View 1 chunk +0 lines, -9 lines 0 comments Download
D base/test/android/javatests/src/org/chromium/base/test/library_loader/TestLibraryLoader.java View 1 chunk +0 lines, -18 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 2 chunks +9 lines, -0 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/remote/device/remote_device_instrumentation_test_run.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/rules.gni View 4 chunks +3 lines, -37 lines 0 comments Download
M build/get_landmines.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/java_apk.gypi View 7 chunks +5 lines, -33 lines 0 comments Download
M net/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/android/BUILD.gn View 2 chunks +1 line, -55 lines 0 comments Download
M net/net.gyp View 4 chunks +4 lines, -69 lines 0 comments Download
D net/test/android/javatests/AndroidManifest.xml View 1 chunk +0 lines, -27 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java View 7 chunks +39 lines, -155 lines 0 comments Download
D net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerImpl.java View 1 chunk +0 lines, -170 lines 0 comments Download
D net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerService.java View 1 chunk +0 lines, -19 lines 0 comments Download
D net/test/android/javatests/src/org/chromium/net/test/IEmbeddedTestServerImpl.aidl View 1 chunk +0 lines, -41 lines 0 comments Download
D net/test/android/javatests/src/org/chromium/net/test/IEmbeddedTestServerInterface.aidl View 1 chunk +0 lines, -5 lines 0 comments Download
D net/test/android/javatests/src_dummy/org/chromium/net/test/dummy/Dummy.java View 1 chunk +0 lines, -11 lines 0 comments Download
D net/test/android/net_test_entry_point.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M net/test/embedded_test_server/android/embedded_test_server_android.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danakj
Created Revert of [Android] Add ChromiumNetTestSupport.apk for the java EmbeddedTestServer.
5 years ago (2015-12-15 20:09:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526183002/1
5 years ago (2015-12-15 20:12:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 20:15:21 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-15 20:16:15 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eb58d9c805c50f85e4a04258523cf49e5c7cc5bb
Cr-Commit-Position: refs/heads/master@{#365309}

Powered by Google App Engine
This is Rietveld 408576698