Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1526123002: VM: Const-correctness fixes. (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Const-correctness fixes. Three types of fixes: 1. Remove redundant const_cast 2. Remove const_cast by adding const when appropiate. 3. Remove const_cast by removing const (e.g. places where we call free with it) For now I only fixed places where the fix is local enough - i.e. does not require changed a large amount of code. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/fbdce6a59e47151a518880cf810d5e6496a2dc2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -48 lines) Patch
M runtime/bin/dartutils.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket.h View 2 chunks +6 lines, -7 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/isolate.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/custom_isolate_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/profiler_service.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/raw_object.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/runtime_entry.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/timeline.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
5 years ago (2015-12-15 17:32:46 UTC) #3
rmacnak
lgtm
5 years ago (2015-12-15 18:13:36 UTC) #4
Florian Schneider
5 years ago (2015-12-15 18:24:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fbdce6a59e47151a518880cf810d5e6496a2dc2c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698