Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1526103002: Shrink SVGPreserveAspectRatio::valueAsString (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
Reviewers:
pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shrink SVGPreserveAspectRatio::valueAsString No need to instantiate String for all the cases. Use a StringBuilder and const char* instead. Shrinks the method by nearly 500 bytes (x86-64) Committed: https://crrev.com/23c967717f23d906c0a57b23e16636835ccdc061 Cr-Commit-Position: refs/heads/master@{#365319}

Patch Set 1 #

Patch Set 2 : Fix Android warning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M third_party/WebKit/Source/core/svg/SVGPreserveAspectRatio.cpp View 1 1 chunk +23 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
Drive-by size-reduction
5 years ago (2015-12-15 18:25:47 UTC) #2
pdr.
On 2015/12/15 at 18:25:47, fs wrote: > Drive-by size-reduction *drives by* *whistles* "nice patch! LGTM" ...
5 years ago (2015-12-15 18:56:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526103002/20001
5 years ago (2015-12-15 18:57:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-15 21:23:57 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 21:24:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/23c967717f23d906c0a57b23e16636835ccdc061
Cr-Commit-Position: refs/heads/master@{#365319}

Powered by Google App Engine
This is Rietveld 408576698