third_party/WebKit/Source/core/frame/VisualViewport.cpp - Issue 1526093006: Fix paint code so that overlays and views paint their own layers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.cpp

Issue 1526093006: Fix paint code so that overlays and views paint their own layers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/VisualViewport.cpp

diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.cpp b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

index f8c396bf23d65aa25220901d4e1a070ed11d4873..1d3882c9c97c2c532652d320368534aba898af0c 100644

--- a/third_party/WebKit/Source/core/frame/VisualViewport.cpp

+++ b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

@@ -276,13 +276,13 @@ bool VisualViewport::magnifyScaleAroundAnchor(float magnifyDelta, const FloatPoi

// | +- *overscrollElasticityLayer

// | +- *pageScaleLayer

// | +- *innerViewportScrollLayer

-// | +-- overflowControlsHostLayer (root layer)

+// | +-- overflowControlsHostLayer (root layer) [ owned by PaintLayerCompositor ]

// | +-- outerViewportContainerLayer (fixed pos container) [frame container layer in PaintLayerCompositor]

// | | +-- outerViewportScrollLayer [frame scroll layer in PaintLayerCompositor]

// | | +-- content layers ...

-// +- horizontalScrollbarLayer

-// +- verticalScrollbarLayer

-// +- scroll corner (non-overlay only)

+// +- horizontalScrollbarLayer [ owned by PaintLayerCompositor ]

+// +- verticalScrollbarLayer [ owned by PaintLayerCompositor ]

+// +- scroll corner (non-overlay only) [ owned by PaintLayerCompositor ]

void VisualViewport::attachToLayerTree(GraphicsLayer* currentLayerTreeRoot, GraphicsLayerFactory* graphicsLayerFactory)

{