media/filters/video_renderer_algorithm_unittest.cc - Issue 1526073003: media: Disable flaky VideoRendererAlgorithmTest.CadenceBasedTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/video_renderer_algorithm_unittest.cc

Issue 1526073003: media: Disable flaky VideoRendererAlgorithmTest.CadenceBasedTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/video_renderer_algorithm_unittest.cc

diff --git a/media/filters/video_renderer_algorithm_unittest.cc b/media/filters/video_renderer_algorithm_unittest.cc

index bc9716a823268348c855e68303e61ea0e12a8383..422bf28d00bb5e8d358714218430d5c33777450b 100644

--- a/media/filters/video_renderer_algorithm_unittest.cc

+++ b/media/filters/video_renderer_algorithm_unittest.cc

@@ -1139,7 +1139,8 @@ TEST_F(VideoRendererAlgorithmTest, RemoveExpiredFramesCadence) {

EXPECT_EQ(0u, algorithm_.EffectiveFramesQueued());

}

-TEST_F(VideoRendererAlgorithmTest, CadenceBasedTest) {

+// TODO(crbug.com/570032): Test disabled for being flaky.

+TEST_F(VideoRendererAlgorithmTest, DISABLED_CadenceBasedTest) {

// Common display rates.

const double kDisplayRates[] = {

NTSC(24),

« no previous file with comments | « no previous file | no next file » | no next file with comments »