Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1526033002: printing: Invoke cups-config from the sysroot if one is being used. (Closed)

Created:
5 years ago by Raphael Kubo da Costa (rakuco)
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

printing: Invoke cups-config from the sysroot if one is being used. The gyp version was relying on cups-config in the host when checking the API version, whereas BUILD.gn was not using the sysroot at all. R=sbc@chromium.org,phajdan.jr@chromium.org,thestig@chromium.org BUG=504446 Committed: https://crrev.com/64f5280c212477b92afde98bce74dd79c63b4537 Cr-Commit-Position: refs/heads/master@{#365600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M printing/BUILD.gn View 3 chunks +11 lines, -2 lines 0 comments Download
M printing/printing.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Raphael Kubo da Costa (rakuco)
5 years ago (2015-12-15 14:44:20 UTC) #1
Lei Zhang
lgtm
5 years ago (2015-12-15 18:07:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526033002/1
5 years ago (2015-12-15 18:33:36 UTC) #4
commit-bot: I haz the power
The author raphael.kubo.da.costa@intel.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years ago (2015-12-15 18:33:38 UTC) #6
Paweł Hajdan Jr.
LGTM
5 years ago (2015-12-16 14:43:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526033002/1
5 years ago (2015-12-16 19:08:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 20:12:55 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-16 20:14:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64f5280c212477b92afde98bce74dd79c63b4537
Cr-Commit-Position: refs/heads/master@{#365600}

Powered by Google App Engine
This is Rietveld 408576698