Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1526023002: [proxies] Recognize arraylike proxies in Object.prototype.toString. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
adamk, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Recognize arraylike proxies in Object.prototype.toString. We must print "[object Array]" for proxies that satisfy Array.isArray. Cosmetic change on the side: move ObjectProtoToString from JSObject to Object since it deals with arbitrary objects. R=adamk@chromium.org, verwaest@chromium.org BUG=v8:1543 LOG=n Committed: https://crrev.com/f723b12336b2ff0ee6a9e6f9a676e4901706ede1 Cr-Commit-Position: refs/heads/master@{#32902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -13 lines) Patch
M src/objects.h View 4 chunks +9 lines, -5 lines 0 comments Download
M src/objects.cc View 4 chunks +17 lines, -6 lines 0 comments Download
M test/mjsunit/es6/object-tostring.js View 2 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
neis
5 years ago (2015-12-15 14:00:23 UTC) #1
Jakob Kummerow
Drive-by nit: the official rule is not to update copyright years when modifying existing files ...
5 years ago (2015-12-15 22:06:09 UTC) #2
adamk
This approach seems fine to me; it moves the code toward what the spec says ...
5 years ago (2015-12-16 09:59:11 UTC) #3
Toon Verwaest
lgtm
5 years ago (2015-12-16 13:36:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526023002/1
5 years ago (2015-12-16 13:38:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 14:27:19 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-16 14:27:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f723b12336b2ff0ee6a9e6f9a676e4901706ede1
Cr-Commit-Position: refs/heads/master@{#32902}

Powered by Google App Engine
This is Rietveld 408576698