Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h

Issue 1525993005: Change CachingWordShapeIterator to delimit CJK characters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TestExpectations Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h
index a616714f32cc50e4e3e273db6d118318ee46ab13..643e826704ba9f9f487ce37a9c9ca7b7a96452da 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h
+++ b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h
@@ -117,9 +117,40 @@ private:
if (m_startIndex + 1u == length || isWordDelimiter(m_textRun[m_startIndex]))
return m_startIndex + 1;
+ // Delimit every CJK character because these scripts do not delimit
+ // words by spaces, and not delimiting hits the performance.
+ if (!m_textRun.is8Bit()) {
+ UChar32 ch;
+ unsigned end = m_startIndex;
+ U16_NEXT(m_textRun.characters16(), end, length, ch);
+ if (Character::isCJKIdeographOrSymbol(ch)) {
+ bool hasAnyScript = !Character::isCommonOrInheritedScript(ch);
+ for (unsigned i = end; i < length; end = i) {
+ U16_NEXT(m_textRun.characters16(), i, length, ch);
+ if (U_GET_GC_MASK(ch) & (U_GC_M_MASK | U_GC_LM_MASK | U_GC_SK_MASK))
+ continue;
+ // Avoid delimiting COMMON/INHERITED alone, which makes harder to
+ // identify the script.
+ if (Character::isCJKIdeographOrSymbol(ch)) {
+ if (Character::isCommonOrInheritedScript(ch))
+ continue;
+ if (!hasAnyScript) {
+ hasAnyScript = true;
+ continue;
+ }
+ }
+ return end;
+ }
+ return length;
+ }
+ }
+
for (unsigned i = m_startIndex + 1; ; i++) {
- if (i == length || isWordDelimiter(m_textRun[i]))
+ if (i == length || isWordDelimiter(m_textRun[i])
+ || (!m_textRun.is8Bit()
+ && Character::isCJKIdeographOrSymbol(m_textRun[i]))) {
return i;
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698