third_party/WebKit/Source/platform/fonts/Character.cpp - Issue 1525993005: Change CachingWordShapeIterator to delimit CJK characters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/Character.cpp

Issue 1525993005: Change CachingWordShapeIterator to delimit CJK characters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactor to clarify what nextWord does and less functions Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/Character.h ('k') | third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h » ('j') | third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/Character.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/Character.cpp b/third_party/WebKit/Source/platform/fonts/Character.cpp

index 5ea155b1d48daef3e9c9c8e70d4b0fd31b8974fe..88b05db5424edf83a29a3bfcc9b95ba90ac86d08 100644

--- a/third_party/WebKit/Source/platform/fonts/Character.cpp

+++ b/third_party/WebKit/Source/platform/fonts/Character.cpp

@@ -34,6 +34,7 @@

#include "wtf/StdLibExtras.h"

#include "wtf/text/StringBuilder.h"

#include <algorithm>

+#include <unicode/uscript.h>

using namespace WTF;

using namespace Unicode;

@@ -512,4 +513,11 @@ String Character::normalizeSpaces(const UChar* characters, unsigned length)

return normalizeSpacesInternal(characters, length);

}

+bool Character::isCommonOrInheritedScript(UChar32 character)

+ UErrorCode status = U_ZERO_ERROR;

+ UScriptCode script = uscript_getScript(character, &status);

+ return U_SUCCESS(status) && (script == USCRIPT_COMMON || script == USCRIPT_INHERITED);

} // namespace blink