Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1525993002: [debugger] remove frame argument for prepare step. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove frame argument for prepare step. The third argument optionally specifies the frame from which to step. This feature is not used and not well tested. R=jkummerow@chromium.org BUG=chromium:569835 LOG=N Committed: https://crrev.com/bead244884b0c2674c0dc40ae6f4f7b4fa198788 Cr-Commit-Position: refs/heads/master@{#32865}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -211 lines) Patch
M src/debug/debug.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/debug/debug.cc View 4 chunks +8 lines, -14 lines 0 comments Download
M src/debug/debug.js View 1 1 chunk +2 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 4 chunks +2 lines, -16 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/debug-step-4.js View 1 2 3 chunks +8 lines, -31 lines 0 comments Download
D test/mjsunit/debug-step-4-in-frame.js View 1 2 1 chunk +0 lines, -132 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Yang
5 years ago (2015-12-15 12:20:00 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525993002/1
5 years ago (2015-12-15 12:20:11 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/11221) v8_linux64_asan_rel on ...
5 years ago (2015-12-15 12:20:58 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525993002/20001
5 years ago (2015-12-15 12:24:10 UTC) #7
Jakob Kummerow
lgtm
5 years ago (2015-12-15 12:50:33 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-15 13:09:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525993002/40001
5 years ago (2015-12-15 13:11:22 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-15 13:36:49 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-15 13:37:32 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bead244884b0c2674c0dc40ae6f4f7b4fa198788
Cr-Commit-Position: refs/heads/master@{#32865}

Powered by Google App Engine
This is Rietveld 408576698