Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1525983002: [proxies] Make Array.prototype.concat work correctly with proxies. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
rossberg, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Make Array.prototype.concat work correctly with proxies. R=rossberg BUG=v8:1543 LOG=n Committed: https://crrev.com/d0ef84b34054f12c66e4cab6e03672d02727b979 Cr-Commit-Position: refs/heads/master@{#32900}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -69 lines) Patch
M src/builtins.cc View 16 chunks +50 lines, -58 lines 0 comments Download
M src/js/runtime.js View 1 chunk +0 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/array-concat.js View 1 2 chunks +167 lines, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-json.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
neis
5 years ago (2015-12-15 12:02:32 UTC) #1
Camillo Bruni
https://codereview.chromium.org/1525983002/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1525983002/diff/1/src/builtins.cc#newcode1154 src/builtins.cc:1154: DCHECK(isolate->IsFastArrayConstructorPrototypeChainIntact()); I don't think this is needed here since ...
5 years ago (2015-12-15 16:23:19 UTC) #3
neis
https://codereview.chromium.org/1525983002/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1525983002/diff/1/src/builtins.cc#newcode1154 src/builtins.cc:1154: DCHECK(isolate->IsFastArrayConstructorPrototypeChainIntact()); On 2015/12/15 16:23:19, cbruni wrote: > I don't ...
5 years ago (2015-12-15 16:25:02 UTC) #4
rossberg
lgtm https://codereview.chromium.org/1525983002/diff/1/test/mjsunit/harmony/array-concat.js File test/mjsunit/harmony/array-concat.js (right): https://codereview.chromium.org/1525983002/diff/1/test/mjsunit/harmony/array-concat.js#newcode731 test/mjsunit/harmony/array-concat.js:731: log.push([trap, ...arguments]); Nit: if you're already using spread, ...
5 years ago (2015-12-16 13:14:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525983002/20001
5 years ago (2015-12-16 13:37:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-16 14:17:23 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-16 14:17:33 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0ef84b34054f12c66e4cab6e03672d02727b979
Cr-Commit-Position: refs/heads/master@{#32900}

Powered by Google App Engine
This is Rietveld 408576698