Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: tests/compiler/dart2js/mock_compiler.dart

Issue 152593002: Version 1.2.0-dev.3.1 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/mock_compiler.dart
===================================================================
--- tests/compiler/dart2js/mock_compiler.dart (revision 32236)
+++ tests/compiler/dart2js/mock_compiler.dart (working copy)
@@ -478,15 +478,22 @@
};
}
-/// [expectedWarnings] must be a list of either [MessageKind] or [CheckMessage].
void compareWarningKinds(String text,
List expectedWarnings,
List<WarningMessage> foundWarnings) {
+ compareMessageKinds(text, expectedWarnings, foundWarnings, 'warning');
+}
+
+/// [expectedMessages] must be a list of either [MessageKind] or [CheckMessage].
+void compareMessageKinds(String text,
+ List expectedMessages,
+ List<WarningMessage> foundMessages,
+ String kind) {
var fail = (message) => Expect.fail('$text: $message');
HasNextIterator expectedIterator =
- new HasNextIterator(expectedWarnings.iterator);
+ new HasNextIterator(expectedMessages.iterator);
HasNextIterator<WarningMessage> foundIterator =
- new HasNextIterator(foundWarnings.iterator);
+ new HasNextIterator(foundMessages.iterator);
while (expectedIterator.hasNext && foundIterator.hasNext) {
var expected = expectedIterator.next();
var found = foundIterator.next();
@@ -496,22 +503,22 @@
String error = expected(found.message);
Expect.isNull(error, error);
} else {
- Expect.fail("Unexpected expectedWarnings value: $expected.");
+ Expect.fail("Unexpected $kind value: $expected.");
}
}
if (expectedIterator.hasNext) {
do {
var expected = expectedIterator.next();
if (expected is CheckMessage) expected = expected(null);
- print('Expected warning "${expected}" did not occur');
+ print('Expected $kind "${expected}" did not occur');
} while (expectedIterator.hasNext);
- fail('Too few warnings');
+ fail('Too few ${kind}s');
}
if (foundIterator.hasNext) {
do {
- print('Additional warning "${foundIterator.next()}"');
+ print('Additional $kind "${foundIterator.next()}"');
} while (foundIterator.hasNext);
- fail('Too many warnings');
+ fail('Too many ${kind}s');
}
}
« no previous file with comments | « tests/compiler/dart2js/message_kind_test.dart ('k') | tests/compiler/dart2js/override_inheritance_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698