Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: impl/memory/user_test.go

Issue 1525923002: Implement Mail service. (Closed) Base URL: https://github.com/luci/gae.git@filter_user
Patch Set: add tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« impl/memory/mail.go ('K') | « impl/memory/user.go ('k') | impl/prod/context.go » ('j') | service/mail/interface.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: impl/memory/user_test.go
diff --git a/impl/memory/user_test.go b/impl/memory/user_test.go
index a49ab7c9cf7ff1afba49719df88b58e8df215778..f96b2e37179c718e009e1aedd36e6498c27a8b67 100644
--- a/impl/memory/user_test.go
+++ b/impl/memory/user_test.go
@@ -89,11 +89,7 @@ func TestUser(t *testing.T) {
Convey("panics on bad email", func() {
So(func() {
user.Testable().Login("bademail", "", false)
- }, ShouldPanicLike, `"bademail" doesn't seem to be a valid email`)
-
- So(func() {
- user.Testable().Login("too@many@ats.com", "", false)
- }, ShouldPanicLike, `"too@many@ats.com" doesn't seem to be a valid email`)
+ }, ShouldPanicLike, `mail: missing phrase`)
martiniss 2015/12/16 21:54:15 Ummm. This error message doesn't mean much to me.
iannucci 2015/12/17 00:01:07 comes from "net/mail"
})
Convey("fake URLs", func() {
« impl/memory/mail.go ('K') | « impl/memory/user.go ('k') | impl/prod/context.go » ('j') | service/mail/interface.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698