service/mail/interface.go - Issue 1525923002: Implement Mail service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: service/mail/interface.go

Issue 1525923002: Implement Mail service. (Closed) Base URL: https://github.com/luci/gae.git@filter_user

Patch Set: add tests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 package mail

	6

	7 // Interface is the interface for all of the mail methods.

	8 type Interface interface {

	9 Send(msg *Message) error

	10 SendToAdmins(msg *Message) error
	martiniss 2015/12/16 21:54:15 Why is this a separate function? Also, do these ne Why is this a separate function? Also, do these need to be documented? iannucci 2015/12/17 00:01:07 These are the same as the functions in the SDK. I' Show quoted text On 2015/12/16 at 21:54:15, martiniss wrote: > Why is this a separate function? Also, do these need to be documented? These are the same as the functions in the SDK. I'll mention that in the interface doc string, but I don't want to copy-paste documentation (that said, the upstream docs are pretty bad too...)
	11

	12 Testable() Testable

	13 }

OLD	NEW