Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1525873002: Panic when non-runtime-handleable type errors occur (Closed)

Created:
5 years ago by iannucci
Modified:
5 years ago
Reviewers:
dnj, Vadim Sh., estaab, martiniss
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Panic when non-runtime-handleable type errors occur R=dnj@chromium.org, estaab@chromium.org, vadimsh@chromium.org BUG=https://github.com/luci/gae/issues/28 Committed: https://github.com/luci/gae/commit/43779b3d75a8e5ac5fb7e0b2c61cbc8378de0aa9

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M service/datastore/datastore.go View 4 chunks +21 lines, -15 lines 0 comments Download
M service/datastore/datastore_test.go View 1 4 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
iannucci
5 years ago (2015-12-15 00:14:04 UTC) #1
iannucci
On 2015/12/15 at 00:14:04, iannucci wrote: > +martiniss
5 years ago (2015-12-15 00:16:41 UTC) #3
martiniss
does this work for GetMulti and PutMulti as well? :)
5 years ago (2015-12-15 00:24:26 UTC) #4
Vadim Sh.
lgtm
5 years ago (2015-12-15 00:24:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525873002/20001
5 years ago (2015-12-15 00:37:30 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-15 00:40:26 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/43779b3d75a8e5ac5fb7e0b2c61cbc8378de0aa9

Powered by Google App Engine
This is Rietveld 408576698