Remove renderer_service -> media_client dependency.

Remove renderer_service -> media_client dependency.

This is in preparation for disentangling media_client from the core
renderer service.

Committed: https://crrev.com/3493e3e22cd5f2404239661f4108364e2be0cfe3
Cr-Commit-Position: refs/heads/master@{#365402}

[alokp, 2015-12-14 23:35:09]

alokp@chromium.org changed reviewers:
+ xhwang@chromium.org

[alokp, 2015-12-14 23:35:09]

Xiaohan: To limit the size of this patch, it just pushes the dependency one
layer up. It also removes unused MojoMediaClient API.

[alokp, 2015-12-14 23:47:02]

https://codereview.chromium.org/1525863002/diff/1/media/mojo/services/mojo_me...
File media/mojo/services/mojo_media_client.h (right):

https://codereview.chromium.org/1525863002/diff/1/media/mojo/services/mojo_me...
media/mojo/services/mojo_media_client.h:32: virtual scoped_ptr<RendererFactory>
CreateRendererFactory(
Can we replace these three functions with a single CreateRenderer function?
Getting a factory only makes sense when you need to cache it somewhere to be
used later. In this case, the mojo application can call CreateRenderer directly
instead of going via a factory.

[xhwang, 2015-12-15 21:51:42]

lgtm % nits

https://chromiumcodereview.appspot.com/1525863002/diff/1/media/mojo/services/...
File media/mojo/services/default_mojo_media_client.cc (right):

https://chromiumcodereview.appspot.com/1525863002/diff/1/media/mojo/services/...
media/mojo/services/default_mojo_media_client.cc:65:
scoped_ptr<AudioHardwareConfig> audio_hardware_config_;
remove?

https://chromiumcodereview.appspot.com/1525863002/diff/1/media/mojo/services/...
File media/mojo/services/mojo_media_client.h (right):

https://chromiumcodereview.appspot.com/1525863002/diff/1/media/mojo/services/...
media/mojo/services/mojo_media_client.h:32: virtual scoped_ptr<RendererFactory>
CreateRendererFactory(
On 2015/12/14 23:47:02, alokp wrote:
> Can we replace these three functions with a single CreateRenderer function?
> Getting a factory only makes sense when you need to cache it somewhere to be
> used later. In this case, the mojo application can call CreateRenderer
directly
> instead of going via a factory.

Agreed that this is not absolutely necessary and the proposal should also work.
But since we use Renderer/Cdm factories in other places, it makes sense to keep
it here for consistency. We can revisit this later.

https://chromiumcodereview.appspot.com/1525863002/diff/1/media/mojo/services/...
File media/mojo/services/mojo_renderer_service.cc (left):

https://chromiumcodereview.appspot.com/1525863002/diff/1/media/mojo/services/...
media/mojo/services/mojo_renderer_service.cc:66: video_renderer.Pass()));
We are losing the ability to create RendererImpl with customized decoders. But I
think it's okay because nobody needs it now :)

[alokp, 2015-12-15 22:41:04]

https://codereview.chromium.org/1525863002/diff/1/media/mojo/services/default...
File media/mojo/services/default_mojo_media_client.cc (right):

https://codereview.chromium.org/1525863002/diff/1/media/mojo/services/default...
media/mojo/services/default_mojo_media_client.cc:65:
scoped_ptr<AudioHardwareConfig> audio_hardware_config_;
On 2015/12/15 21:51:41, xhwang wrote:
> remove?

Done.

https://codereview.chromium.org/1525863002/diff/1/media/mojo/services/mojo_me...
File media/mojo/services/mojo_media_client.h (right):

https://codereview.chromium.org/1525863002/diff/1/media/mojo/services/mojo_me...
media/mojo/services/mojo_media_client.h:32: virtual scoped_ptr<RendererFactory>
CreateRendererFactory(
On 2015/12/15 21:51:41, xhwang wrote:
> On 2015/12/14 23:47:02, alokp wrote:
> > Can we replace these three functions with a single CreateRenderer function?
> > Getting a factory only makes sense when you need to cache it somewhere to be
> > used later. In this case, the mojo application can call CreateRenderer
> directly
> > instead of going via a factory.
> 
> Agreed that this is not absolutely necessary and the proposal should also
work.
> But since we use Renderer/Cdm factories in other places, it makes sense to
keep
> it here for consistency. We can revisit this later.

Acknowledged.

[alokp, 2015-12-15 22:44:26]

The CQ bit was checked by alokp@chromium.org

[alokp, 2015-12-15 22:44:26]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1525863002/#ps20001
(title: "removed unnecessary member variable")

[commit-bot: I haz the power, 2015-12-15 22:45:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525863002/20001

[alokp, 2015-12-15 22:46:27]

The CQ bit was unchecked by alokp@chromium.org

[alokp, 2015-12-15 22:48:17]

https://codereview.chromium.org/1525863002/diff/1/media/mojo/services/default...
File media/mojo/services/default_mojo_media_client.cc (right):

https://codereview.chromium.org/1525863002/diff/1/media/mojo/services/default...
media/mojo/services/default_mojo_media_client.cc:65:
scoped_ptr<AudioHardwareConfig> audio_hardware_config_;
On 2015/12/15 22:41:04, alokp wrote:
> On 2015/12/15 21:51:41, xhwang wrote:
> > remove?
> 
> Done.

Actually this is needed to create DefaultRendererFactory

[xhwang, 2015-12-15 22:51:00]

On 2015/12/15 22:48:17, alokp wrote:
>
https://codereview.chromium.org/1525863002/diff/1/media/mojo/services/default...
> File media/mojo/services/default_mojo_media_client.cc (right):
> 
>
https://codereview.chromium.org/1525863002/diff/1/media/mojo/services/default...
> media/mojo/services/default_mojo_media_client.cc:65:
> scoped_ptr<AudioHardwareConfig> audio_hardware_config_;
> On 2015/12/15 22:41:04, alokp wrote:
> > On 2015/12/15 21:51:41, xhwang wrote:
> > > remove?
> > 
> > Done.
> 
> Actually this is needed to create DefaultRendererFactory

Oh, yes, sorry I missed that.

[alokp, 2015-12-15 22:55:22]

The CQ bit was checked by alokp@chromium.org

[alokp, 2015-12-15 22:55:22]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1525863002/#ps40001
(title: "fixed compile error")

[commit-bot: I haz the power, 2015-12-15 22:57:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525863002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525863002/40001

[commit-bot: I haz the power, 2015-12-16 00:26:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-16 00:28:30]

Description was changed from

==========
Remove renderer_service -> media_client dependency.

This is in preparation for disentangling media_client from the core
renderer service.
==========

to

==========
Remove renderer_service -> media_client dependency.

This is in preparation for disentangling media_client from the core
renderer service.

Committed: https://crrev.com/3493e3e22cd5f2404239661f4108364e2be0cfe3
Cr-Commit-Position: refs/heads/master@{#365402}
==========

[commit-bot: I haz the power, 2015-12-16 00:28:31]

Patchset 3 (id:??) landed as
https://crrev.com/3493e3e22cd5f2404239661f4108364e2be0cfe3
Cr-Commit-Position: refs/heads/master@{#365402}