third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm - Issue 1525803002: Make ScrollbarThemeAura selectively invalidate scrollbar parts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

Issue 1525803002: Make ScrollbarThemeAura selectively invalidate scrollbar parts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit tests for invalidation of scrollbar parts Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp » ('j') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

diff --git a/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm b/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

index c99941a35cdfe2a578c2336491ea707c89c94a83..bd20c5a7b9199178ec922ae04f456a5cb2065e9b 100644

--- a/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

+++ b/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

@@ -428,20 +428,17 @@ private:

break;

case TrackAlpha:

[_scrollbarPainter.get() setTrackAlpha:currentValue];

- _scrollbar->setTrackNeedsRepaint(true);

+ _scrollbar->setNeedsPaintInvalidation(static_cast<ScrollbarPart>(~ThumbPart));

break;

case UIStateTransition:

[_scrollbarPainter.get() setUiStateTransitionProgress:currentValue];

- _scrollbar->setThumbNeedsRepaint(true);

- _scrollbar->setTrackNeedsRepaint(true);

+ _scrollbar->setNeedsPaintInvalidation();

break;

case ExpansionTransition:

[_scrollbarPainter.get() setExpansionTransitionProgress:currentValue];

- _scrollbar->setThumbNeedsRepaint(true);

+ _scrollbar->setNeedsPaintInvalidation(ThumbPart);

break;

}

- _scrollbar->setNeedsPaintInvalidation();

}

- (void)invalidate