third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 1525803002: Make ScrollbarThemeAura selectively invalidate scrollbar parts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1525803002: Make ScrollbarThemeAura selectively invalidate scrollbar parts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit tests for invalidation of scrollbar parts Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp » ('j') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 2b39cef0087c0e4cb469a6efcfbe03e09d21d7c8..2664cfd0b7169782cda564de081e5ef796be041e 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -2073,10 +2073,8 @@ void FrameView::scrollTo(const DoublePoint& newPosition)

void FrameView::invalidatePaintForTickmarks()

{

- if (Scrollbar* scrollbar = verticalScrollbar()) {

- scrollbar->setTrackNeedsRepaint(true);

- setScrollbarNeedsPaintInvalidation(VerticalScrollbar);

- }

+ if (Scrollbar* scrollbar = verticalScrollbar())

+ scrollbar->setNeedsPaintInvalidation(static_cast<ScrollbarPart>(~ThumbPart));

}

void FrameView::getTickmarks(Vector<IntRect>& tickmarks) const