Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1525803002: Make ScrollbarThemeAura selectively invalidate scrollbar parts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove TODO, per ccameron Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2055 matching lines...) Expand 10 before | Expand all | Expand 10 after
2066 m_pendingScrollDelta += scrollDelta; 2066 m_pendingScrollDelta += scrollDelta;
2067 2067
2068 clearScrollAnchor(); 2068 clearScrollAnchor();
2069 updateLayersAndCompositingAfterScrollIfNeeded(); 2069 updateLayersAndCompositingAfterScrollIfNeeded();
2070 scrollPositionChanged(); 2070 scrollPositionChanged();
2071 frame().loader().client()->didChangeScrollOffset(); 2071 frame().loader().client()->didChangeScrollOffset();
2072 } 2072 }
2073 2073
2074 void FrameView::invalidatePaintForTickmarks() 2074 void FrameView::invalidatePaintForTickmarks()
2075 { 2075 {
2076 if (Scrollbar* scrollbar = verticalScrollbar()) { 2076 if (Scrollbar* scrollbar = verticalScrollbar())
2077 scrollbar->setTrackNeedsRepaint(true); 2077 scrollbar->setNeedsPaintInvalidation(static_cast<ScrollbarPart>(~ThumbPa rt));
skobes 2015/12/28 17:48:39 Why do we exclude ThumbPart here?
jbroman 2015/12/29 16:45:14 The previous version of the code invalidates the t
2078 setScrollbarNeedsPaintInvalidation(VerticalScrollbar);
2079 }
2080 } 2078 }
2081 2079
2082 void FrameView::getTickmarks(Vector<IntRect>& tickmarks) const 2080 void FrameView::getTickmarks(Vector<IntRect>& tickmarks) const
2083 { 2081 {
2084 if (!m_tickmarks.isEmpty()) 2082 if (!m_tickmarks.isEmpty())
2085 tickmarks = m_tickmarks; 2083 tickmarks = m_tickmarks;
2086 else 2084 else
2087 tickmarks = frame().document()->markers().renderedRectsForMarkers(Docume ntMarker::TextMatch); 2085 tickmarks = frame().document()->markers().renderedRectsForMarkers(Docume ntMarker::TextMatch);
2088 } 2086 }
2089 2087
(...skipping 1918 matching lines...) Expand 10 before | Expand all | Expand 10 after
4008 return m_hiddenForThrottling && m_crossOriginForThrottling; 4006 return m_hiddenForThrottling && m_crossOriginForThrottling;
4009 } 4007 }
4010 4008
4011 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const 4009 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const
4012 { 4010 {
4013 ASSERT(layoutView()); 4011 ASSERT(layoutView());
4014 return *layoutView(); 4012 return *layoutView();
4015 } 4013 }
4016 4014
4017 } // namespace blink 4015 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698