Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1525793006: Revert of Load data URI images in an async way according to spec (Closed)

Created:
5 years ago by Yoav Weiss
Modified:
5 years ago
Reviewers:
pdr., esprehn, Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Load data URI images in an async way according to spec (patchset #2 id:20001 of https://codereview.chromium.org/1492303003/ ) Reason for revert: Perf regressions: https://code.google.com/p/chromium/issues/detail?id=569023 Original issue's description: > Load data URI images in an async way according to spec > > According to https://github.com/ResponsiveImagesCG/picture-element/issues/223#issuecomment-69772765 > we seem to be the only browser that loads data URIs immediately (as if they were cached). > It was introduced as part of the move to async image loading: https://codereview.chromium.org/200923002 > > This is now causing issues: https://code.google.com/p/chromium/issues/detail?id=469131 > > This CL changes this behavior to be spec compliant and load data URIs asynchronously, like other resources. > > This is bringing https://codereview.chromium.org/1256233002/ to the Chromium repo. > > BUG=514206 > > Committed: https://crrev.com/91aa6fb579a1f656ef274ebe73e426db99b5f52f > Cr-Commit-Position: refs/heads/master@{#363444} TBR=pdr@chromium.org,mkwst@chromium.org,esprehn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=514206 Committed: https://crrev.com/c060e8f3902edd6f9b920d7a5ac23d17ec344dd2 Cr-Commit-Position: refs/heads/master@{#365498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -99 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-out-of-bounds-src.html View 2 chunks +10 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/image-async-loading-data-uris.html View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/basic-buttons.html View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/loader/data-uri-images-load-asynchronously.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/loader/data-uri-images-load-asynchronously-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/loader/data-uri-images-load-synchronously.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/loader/data-uri-images-load-synchronously-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/loader/data-uri-images-reload-asynchronously.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/loader/data-uri-images-reload-asynchronously-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/loader/data-uri-images-reload-synchronously.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/loader/data-uri-images-reload-synchronously-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/canvas/canvas-draw-image-globalalpha.html View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/canvas/image-svg-intrinsic-size.html View 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Yoav Weiss
Created Revert of Load data URI images in an async way according to spec
5 years ago (2015-12-16 07:31:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525793006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525793006/1
5 years ago (2015-12-16 07:32:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 07:33:25 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-16 07:34:24 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c060e8f3902edd6f9b920d7a5ac23d17ec344dd2
Cr-Commit-Position: refs/heads/master@{#365498}

Powered by Google App Engine
This is Rietveld 408576698