Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java

Issue 1525793005: Move Tab's top controls visibility to a delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed getContentViewCore related logic Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
index e0f305e318698720615abaeb94eb2a24b9409a03..b20e90612e94f646a19604557a113c128494c27f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
@@ -12,6 +12,7 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.compositor.layouts.LayoutManagerDocument;
import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.chrome.browser.tab.TabDelegateFactory;
import org.chromium.chrome.browser.tabmodel.SingleTabModelSelector;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;
@@ -30,8 +31,7 @@ import java.io.File;
* the regular browser's UI is either unnecessary or undesirable.
* Subclasses can override {@link #createUI()} if they need something more exotic.
*/
-public abstract class FullScreenActivity extends ChromeActivity
- implements FullScreenActivityTab.TopControlsVisibilityDelegate {
+public abstract class FullScreenActivity extends ChromeActivity {
private FullScreenActivityTab mTab;
@Override
@@ -62,8 +62,8 @@ public abstract class FullScreenActivity extends ChromeActivity
@Override
public void finishNativeInitialization() {
- mTab = FullScreenActivityTab.create(
- this, getWindowAndroid(), getActivityDirectory(), getSavedInstanceState(), this);
+ mTab = FullScreenActivityTab.create(this, getWindowAndroid(),
+ getActivityDirectory(), getSavedInstanceState(), createTabDelegateFactory());
getTabModelSelector().setTab(mTab);
mTab.show(TabSelectionType.FROM_NEW);
@@ -90,18 +90,19 @@ public abstract class FullScreenActivity extends ChromeActivity
}
/**
+ * @return {@link TabDelegateFactory} to be used while creating the associated {@link Tab}.
+ */
+ protected TabDelegateFactory createTabDelegateFactory() {
+ return new FullScreenDelegateFactory();
+ }
+
+ /**
* @return {@link File} pointing at a directory specific for this class.
*/
protected File getActivityDirectory() {
return null;
}
- // Implements {@link FullScreenActivityTab.TopControlsVisibilityDelegate}.
- @Override
- public boolean shouldShowTopControls(String url, int securityLevel) {
- return false;
- }
-
@Override
protected boolean handleBackPressed() {
if (mTab == null) return false;

Powered by Google App Engine
This is Rietveld 408576698