chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java - Issue 1525793005: Move Tab's top controls visibility to a delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

Issue 1525793005: Move Tab's top controls visibility to a delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed getContentViewCore related logic Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/TopControlsVisibilityDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

index aa616f273411125ede953ee8d66f391b0b8e3969..da692ed80cdd081bbc57720fb5037b6ce1d9e408 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

@@ -57,4 +57,13 @@ public class TabDelegateFactory {

public AppBannerManager createAppBannerManager(Tab tab) {

return new AppBannerManager(tab, tab.getApplicationContext());

}

+ /**

+ * Creates the {@link TopControlsVisibilityDelegate} the tab will be initialized with.

+ * @param tab The associated {@link Tab}.

+ * @return {@link TopControlsVisibilityDelegate} to be used for the given tab.

+ */

+ public TopControlsVisibilityDelegate createTopControlsVisibilityDelegate(Tab tab) {

+ return new TopControlsVisibilityDelegate(tab);

+ }

}