Fall back to title element text for SVG root text alternatives

third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

 /*
  * Copyright (C) 2012, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 36 matching lines @@
 #include "core/html/HTMLTableCaptionElement.h"
 #include "core/html/HTMLTableCellElement.h"
 #include "core/html/HTMLTableElement.h"
 #include "core/html/HTMLTableRowElement.h"
 #include "core/html/HTMLTableSectionElement.h"
 #include "core/html/HTMLTextAreaElement.h"
 #include "core/html/parser/HTMLParserIdioms.h"
 #include "core/html/shadow/MediaControlElements.h"
 #include "core/layout/LayoutBlockFlow.h"
 #include "core/layout/LayoutObject.h"
+#include "core/svg/SVGElement.h"
 #include "modules/accessibility/AXObjectCacheImpl.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/text/PlatformLocale.h"
 #include "wtf/text/StringBuilder.h"
 
 
 namespace blink {
 
 using namespace HTMLNames;
 
@@ skipping 2303 matching lines @@
                 source.text = textAlternative;
                 *foundTextAlternative = true;
             } else {
                 return textAlternative;
             }
         }
 
         return textAlternative;
     }
 
+    // Per SVG AAM 1.0's modifications to 2D of this algorithm.
+    if (node()->isSVGElement()) {
+        nameFrom = AXNameFromRelatedElement;
+        if (nameSources) {
+            nameSources->append(NameSource(*foundTextAlternative));
+            nameSources->last().type = nameFrom;
+            nameSources->last().nativeSource = AXTextFromNativeHTMLTitleElement;
+        }
+        Element* title = nullptr;
+        for (Element& element : ElementTraversal::descendantsOf(*(node()))) {

[aboxhall, 2016/01/06 17:04:07]

Could this be simplified to
Element* title = ElementTraversal:firstChild(*(node()),
HasTagName(SVGNames::titleTag))
?

[Elly Fong-Jones, 2016/01/07 18:46:00]

Oooh, TIL! Thanks :D

[Elly Fong-Jones, 2016/01/07 18:46:01]

Done.

+            if (element.hasTagName(SVGNames::titleTag)) {
+                title = &element;
+                break;
+            }
+        }
+
+        if (title) {
+            String text = title->innerText();

[aboxhall, 2016/01/06 17:04:07]

This should follow the same pattern used by fieldset/legend below, i.e.
- get the AXObject for the title element
- ensure we haven't already gotten its text alternative (e.g. if <title> had an
aria-labelledby which referred back to either itself or an ancestor - I actually
had a confusing crash for a little while because of this!)
- call recursiveTextAlternative on the title AXObject
- also, ensure that relatedObjects is correctly populated.

[Elly Fong-Jones, 2016/01/07 18:46:00]

Done.

+            textAlternative = text;
+            if (nameSources) {
+                NameSource& source = nameSources->last();
+                source.text = textAlternative;
+                *foundTextAlternative = true;
+            } else {
+                return textAlternative;
+            }
+        }
+
+        return textAlternative;
+    }
+
     // Fieldset / legend.
     if (isHTMLFieldSetElement(node())) {
         nameFrom = AXNameFromRelatedElement;
         if (nameSources) {
             nameSources->append(NameSource(*foundTextAlternative));
             nameSources->last().type = nameFrom;
             nameSources->last().nativeSource = AXTextFromNativeHTMLLegend;
         }
         HTMLElement* legend = toHTMLFieldSetElement(node())->legend();
         if (legend) {
@@ skipping 312 matching lines @@
     return placeholder;
 }
 
 DEFINE_TRACE(AXNodeObject)
 {
     visitor->trace(m_node);
     AXObject::trace(visitor);
 }
 
 } // namespace blin