Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp

Issue 1525793002: Fall back to title element text for SVG root text alternatives (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: + AXSVGRoot override Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 { 61 {
62 ASSERT(!isDetached()); 62 ASSERT(!isDetached());
63 // If a parent was set because this is a remote SVG resource, use that 63 // If a parent was set because this is a remote SVG resource, use that
64 // but otherwise, we should rely on the standard layout tree for the parent. 64 // but otherwise, we should rely on the standard layout tree for the parent.
65 if (m_parent) 65 if (m_parent)
66 return m_parent; 66 return m_parent;
67 67
68 return AXLayoutObject::computeParent(); 68 return AXLayoutObject::computeParent();
69 } 69 }
70 70
71 bool AXSVGRoot::computeAccessibilityIsIgnored(IgnoredReasons* reasons) const
aboxhall 2015/12/15 19:56:03 Let's revert this for this change, and use the rol
dmazzoni 2015/12/15 20:00:45 Why? What's wrong with keeping the SVG root elemen
72 {
73 return false;
74 }
71 75
72 } // namespace blink 76 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698